commit 33ad20eea4c75a4911dcdc6ad3758501187feb6b · @notnite.com/moonlight

@notnite.com / moonlight

this repo has no description

Oops, setConfigOption should be async

NotNite 1 month ago 3 files (+5, -5)

33ad20ee 441b4504

Changed files

packages/browser/src/index.ts

packages/node-preload/src/index.ts

packages/types/src/globals.ts

MODIFIED packages/browser/src/index.ts

@@ -127,9 +127,9 @@ getConfigOption(ext, name) {
       const manifest = getManifest(extensions, ext);
       return getConfigOption(ext, name, config, manifest?.settings);
     },
-    setConfigOption(ext, name, value) {
+    async setConfigOption(ext, name, value) {
       setConfigOption(config, ext, name, value);
-      this.writeConfig(config);
+      await this.writeConfig(config);
     },
 
     getNatives: () => {},

MODIFIED packages/node-preload/src/index.ts

@@ -62,9 +62,9 @@ getConfigOption(ext, name) {
       const manifest = getManifest(extensions, ext);
       return getConfigOption(ext, name, config, manifest?.settings);
     },
-    setConfigOption(ext, name, value) {
+    async setConfigOption(ext, name, value) {
       setConfigOption(config, ext, name, value);
-      this.writeConfig(config);
+      await this.writeConfig(config);
     },
     async writeConfig(newConfig) {
       await writeConfig(newConfig);

MODIFIED packages/types/src/globals.ts

@@ -40,7 +40,7 @@ branch: MoonlightBranch;
 
   getConfig: (ext: string) => ConfigExtension["config"];
   getConfigOption: <T>(ext: string, name: string) => T | undefined;
-  setConfigOption: <T>(ext: string, name: string, value: T) => void;
+  setConfigOption: <T>(ext: string, name: string, value: T) => Promise<void>;
   writeConfig: (config: Config) => Promise<void>;
 
   getNatives: (ext: string) => any | undefined;